Enable development of vw locally #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible integer overflow when converting int -> uint16. This bug may never occur, but it is better to have proper handling of this case. Signed-off-by: Atanas Alexandrov <sirakov@gmail.com>
Such type conversions may be omitted Signed-off-by: Atanas Alexandrov <sirakov@gmail.com>
🐛 Fix probable bug
…nversion 🌱 Remove redundant type conversion
Signed-off-by: Hasan Turken <turkenh@gmail.com>
✨ Add original user/group as extra to the impersonating client used by virtual workspace
Some variable names are same like reserved words. This should be avoided Signed-off-by: Atanas Alexandrov <sirakov@gmail.com>
…riable-name 🌱 Rename variables
Should be avoided because the package exported identifiers can't be used after the declaration. This may be also confusing for the reader. Variable renaming is aligned to the official golang guidelines: 'Variable names in Go should be short rather than long. This is especially true for local variables with limited scope. Prefer c to lineCount. Prefer i to sliceIndex'. Source: https://go.dev/wiki/CodeReviewComments#variable-names Signed-off-by: Atanas Alexandrov <sirakov@gmail.com>
…e-as-name-identifier 🐛 Fix probable bug: imported package name as name identifier
…y.regression 🐛 Fix regression when generating deep copy
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
✨ Update ADOPTERS.md
On-behalf-of: @SAP marvin.beckers@sap.com Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
📖 Fix wrong 'labels' key in adopters issue template
In this functions the returned errors are always nil. They can be removed and this makes the code a little bit simpler. Signed-off-by: Atanas Alexandrov <sirakov@gmail.com>
🐛 Terminate kcp process if controller installation fails
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
🌱 Remove unused return value (error)
📖 Update Kubermatic adopter entry
mjudeikis
force-pushed
the
mjudeikis/workspace.status.merges
branch
from
7a42025 to
141f375
Compare
…atus.merges ✨ Add workspace phase update logic
mjudeikis
force-pushed
the
mjudeikis/vw.dev
branch
2 times, most recently
from
0a4b302 to
9cea6c7
Compare
On-behalf-of: @SAP marvin.beckers@sap.com Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
🌱 Use Go 1.22.9
mjudeikis
force-pushed
the
mjudeikis/vw.dev
branch
from
3cad42b to
26b8a6c
Compare
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP marvin.beckers@sap.com Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
On-behalf-of: @SAP marvin.beckers@sap.com Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Mangirdas Judeikis <Mangirdas@Judeikis.LT> On-behalf-of: SAP mangirdas.judeikis@sap.com
🌱 Bump golangci-lint, remove staticcheck
⚠️ Stop building artefacts for ppc64le
🌱 Update to Go 1.22.10
🐛 Fix impersonation for non-system users
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
📖 Add SAP (ApeiroRA) as adopters
On-behalf-of: @SAP christoph.mewes@sap.com
…e kcp options On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
Signed-off-by: alingse <alingse@foxmail.com>
🐛 fix check `deleteError != nil` but return an other nil value `err`
✨ Enable webhook authorization options
…mages ✨ Add prefix to dev images for gc
mjudeikis
force-pushed
the
mjudeikis/vw.dev
branch
from
95d91aa to
35f051d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows to provide mapping file locally so when developing VirtualWorkspaces using framework you can use
kcp startRelated issue(s)
Fixes #