Skip to content

Commit

Permalink
update to github action actions/upload-artifact@v4 from v3
Browse files Browse the repository at this point in the history
we'll now get a coverage file artifact for each of the builds. we do two
builds, and the last was likely overwriting the coverage file "artifact" of the
first.

hopefully fixes the test. can't test it locally...
  • Loading branch information
mjl- committed Jan 23, 2025
1 parent acc1c13 commit 7df5407
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ jobs:
# Need to run tests with a temp dir on same file system for os.Rename to succeed.
- run: 'mkdir -p tmp && TMPDIR=$PWD/tmp make test'

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: coverage-${{ matrix.runs-on }}
path: cover.html

# Format code, we check below if nothing changed.
Expand Down

0 comments on commit 7df5407

Please sign in to comment.