Add "mc support upload" encryption #5113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `--enc` parameter to `mc support upload` to encrypt the file content. * Add file size as zstd frame content size. * Test opening the file before doing more. * Uses same key as "mc support inspect".
zveinn
approved these changes
Jan 21, 2025
|
Sure @klauspost I will test and update |
Co-authored-by: Shireesh Anjal <355479+anjalshireesh@users.noreply.github.com>
anjalshireesh
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
LGTM, tested, working fine. (tested mc support inspect also)
@klauspost the inspect command allows using custom keys.
Line 165 in 423ef1b
|
@anjalshireesh We never use it, so didn't bother. We can always add it, if we ever should get a use for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--encparameter tomc support uploadto encrypt the file content.mc support inspect.How to test this PR?
@anjalshireesh - would it be possible for you to test the upload? We will probably need to make changes to
inspectbut I would need a test file to verifyTypes of changes