Merge pull request #1132 from rdunlop/patch-1

Version check hangs on ruby 3 with certain gem combination
mileszs · Nov 4, 2024 · 2bf120d · 2bf120d
2 parents 5a4c76a + 5dc8a89
commit 2bf120d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/wicked_pdf/binary.rb b/lib/wicked_pdf/binary.rb
@@ -38,7 +38,9 @@ def xvfb_run_path
     private
 
     def retrieve_binary_version
-      _stdin, stdout, _stderr = Open3.popen3(@path + ' -V')
+      stdin, stdout, stderr = Open3.popen3(@path + ' -V')
+      stdin.close
+      stderr.close
       parse_version_string(stdout.gets(nil))
     rescue StandardError
       default_version