Suppress some warnings in WebGPU EP generated by GCC 13 #23445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be helpful for future tracking if we can split the changes in this PR into:
Some issues related to strict aliasing may be fixed by using |
snnn
changed the title
|
The changes in this PR are not in main yet. |
snnn
commented
Jan 28, 2025
| #pragma GCC diagnostic ignored "-Wstrict-aliasing" | ||
| #endif | ||
|
|
||
| #include <webgpu/webgpu_cpp.h> |
There was a problem hiding this comment.
This change is for suppressing strict-aliasing warnings from the 3rd-party webgpu source code, not ours.
fs-eire
reviewed
Jan 28, 2025
|
|
||
| #if defined(__GNUC__) | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wstrict-aliasing" |
There was a problem hiding this comment.
do we no longer need to use macro HAS_* like this
onnxruntime/cmake/CMakeLists.txt
Line 750 in 655a23f
There was a problem hiding this comment.
We only support GCC 11 and above. "--strict-aliasing" is available in these GCC versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress some warnings generated by GCC 13 by introducing a wrapper for WebGPU header files.