Remove urllib3 upper bound version constraint #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamchainz It's not uncommon for us to pin versions, often at least to major versions. For packages that follow semver closely (not all do), that's typically safe. Though not always. |
|
Sure, but you have to balance making your library safer against breakage versus blocking users from upgrading, which may be safer for them. I don’t want to downgrade urllib3 since it might break things in my project or make it less secure. |
|
@adamchainz I have no problems with the latest version, assuming it is verified to work. Though I can't speak to some future 3.x version. |
|
...so will you merge and release this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2142
Description
Remove the upper version bound constraint added in #2051. It’s unclear why it was added as @tracyboehrer left no notes. See this mega blog post for a long explanier on why libraries should avoid such constraints.
Specific Changes
Per title
Testing
Relying on CI.