Skip to content

Commit

Permalink
Fix addSpnToEnvironment casing bug due to difference in casing (#12934
Browse files Browse the repository at this point in the history
) (#12959)

* Fix `addSpnToEnvironment` casing bug #12933

* Update task.json

* Update task.loc.json

Co-authored-by: Bishal Prasad <biprasad@microsoft.com>
Co-authored-by: Nitin Issac Joy <nijoy@microsoft.com>
Co-authored-by: Nitin Issac Joy <nitin.i.joy@gmail.com>

Co-authored-by: Lawrence Gripper <info@grippers.co.uk>
Co-authored-by: Bishal Prasad <biprasad@microsoft.com>
  • Loading branch information
3 people authored May 24, 2020
1 parent 2f534e9 commit 2043332
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Tasks/AzureCLIV2/azureclitask.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export class azureclitask {
});

var addSpnToEnvironment: boolean = tl.getBoolInput("addSpnToEnvironment", false);
if (!!addSpnToEnvironment && tl.getEndpointAuthorizationScheme(connectedService, true) == "ServicePrincipal") {
if (!!addSpnToEnvironment && tl.getEndpointAuthorizationScheme(connectedService, true).toLowerCase() == "serviceprincipal") {
exitCode = await tool.exec({
failOnStdErr: false,
ignoreReturnCode: true,
Expand Down
2 changes: 1 addition & 1 deletion Tasks/AzureCLIV2/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"version": {
"Major": 2,
"Minor": 0,
"Patch": 12
"Patch": 14
},
"minimumAgentVersion": "2.0.0",
"instanceNameFormat": "Azure CLI $(scriptPath)",
Expand Down
4 changes: 2 additions & 2 deletions Tasks/AzureCLIV2/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"version": {
"Major": 2,
"Minor": 0,
"Patch": 12
"Patch": 14
},
"minimumAgentVersion": "2.0.0",
"instanceNameFormat": "ms-resource:loc.instanceNameFormat",
Expand Down Expand Up @@ -198,4 +198,4 @@
"GlobalCliConfigAgentVersionWarning": "ms-resource:loc.messages.GlobalCliConfigAgentVersionWarning",
"UnacceptedScriptLocationValue": "ms-resource:loc.messages.UnacceptedScriptLocationValue"
}
}
}

0 comments on commit 2043332

Please sign in to comment.