[Breaking Change] Make transport settings required #639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current listener and proxy creation logic falls-back on creating insecure listeners and proxies when transport settings are not defined.
This change updates the behaviour to throw when no transport settings are provider or transport settings cannot be loaded from the TransportSettings section of the hosting service's settings.xml file.
Since transport settings can still be defined explicitly, the implementation still allows for insecure connection creation, if the user understands well how to initialise transport settings in an insecure way.
However, most users will use defaults, or follow the Service Fabric documentation which details using LoadFrom to set up secure remoting, so this is not a concern.
FabricTransportSettings.LoadFrom could have been used instead but I think having a descriptive exception message is valuable, so kept TryLoadFrom.