Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nmdc-schema from 10.0.0 to 10.1.0 #486

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

aclum
Copy link
Contributor

@aclum aclum commented Mar 1, 2024

Description

Upping nmdc-scheam from 10.0.0 to 10.1.0 to add new file type enums for binning.

@aclum aclum requested review from eecavanna and pkalita-lbl March 1, 2024 22:14
@eecavanna
Copy link
Collaborator

eecavanna commented Mar 1, 2024

TODO

  • Synchronize the full dependency file with the "input" one, by running make update-deps within the containerized development environment
  • Check whether this schema change involves any database migrations

@aclum
Copy link
Contributor Author

aclum commented Mar 1, 2024

@eecavanna doesn't the first item happen with the github actions? There are no migrations for 10.0.0 to 10.1.0 based on there not being a migration python script.

@eecavanna
Copy link
Collaborator

eecavanna commented Mar 1, 2024

doesn't the first item happen with the github actions?

I'll check the code to refresh my memory, but I don't think GitHub Actions (currently) takes care of that. I think the GitHub Actions workflows were written under the assumption that the developer would have already done that. Here's what some (maybe obsolete) development documentation says:

nmdc-runtime/docs/admin.md

Lines 97 to 101 in aca4339

## nmdc-schema update
1. Set the desired version of `nmdc-schema` in `requirements/main.in`.
2. `make update-deps`.
3. commit and push, start PR and seek approval + merge to `main`, which will trigger GH actions to deploy.

There are no migrations for 10.0.0 to 10.1.0 based on there not being a migration python script.

You're right, there is no migrator in the nmdc-schema repo defined for this version change. I was expecting there to be a "no op" migrator defined in nmdc-schema (as an explicit indicator that there is, indeed, no migration necessary). I'll check whether that's documented somewhere (I have forgotten).


Anyway, I'll run $ make update-deps on this branch locally, and then push up the changes that get generated, if there are any. I'll report back when done.

@eecavanna
Copy link
Collaborator

eecavanna commented Mar 1, 2024

On my host machine, I ran the following command to attach to a bash shell running inside the fastapi container:

docker compose exec fastapi bash

In that container, I ran:

# make update-deps
pip install --upgrade pip-tools pip setuptools
Requirement already satisfied: pip-tools in /usr/local/lib/python3.10/site-packages (7.3.0)
Collecting pip-tools
  Downloading pip_tools-7.4.0-py3-none-any.whl.metadata (26 kB)
Requirement already satisfied: pip in /usr/local/lib/python3.10/site-packages (23.3.2)
Collecting pip
  Downloading pip-24.0-py3-none-any.whl.metadata (3.6 kB)
(...)

Next, I confirmed that the main.txt file contained this:

nmdc-schema==10.1.0
    # via -r requirements/main.in

Finally, I commited those changes to my local copy of this branch and pushed them up to GitHub so they would be included in this PR.

@eecavanna eecavanna changed the title bump nmdc-schema from 10.0.0 to 10.1.0 Bump nmdc-schema from 10.0.0 to 10.1.0 Mar 1, 2024
@eecavanna
Copy link
Collaborator

eecavanna commented Mar 5, 2024

Hi @aclum, I'll merge this in now. As a result, the development environment will be updated "from schema version 10.0.0 to schema version 10.1.0."

@eecavanna eecavanna merged commit ede3719 into main Mar 5, 2024
1 check passed
@eecavanna eecavanna deleted the update-nmdc-schema-to-v10.1.0 branch March 5, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants