Set source_client to field_notes when generating new submission #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eecavanna
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Looks good to me!
FYI @yxu-lanl, I found this straightforward to review after having reviewed the corresponding changes in nmdc-server. Basically, when either the submission portal or the mobile app creates a submission, it will include this information saying what type of client initialized the submission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128
This is a follow-on to microbiomedata/nmdc-server#1300.
When a new submission is generated by the Field Notes app (
src/data.ts), set thesource_clientfield tofield_notes.I made one of the mock submissions used in tests (
src/mocks/fixtures.ts) have asource_clientofsubmission_portaljust to ensure that we don't do anything with thesource_clientfield that implicitly assumes a value offield_notescoming from the backend.