Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI Fortran Modernization Part 2 #405

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ohearnk
Copy link
Collaborator

@ohearnk ohearnk commented Mar 2, 2025

NOTE: the branch in the PR is based off of the work in #361, so merge that PR first before merging this work.

This PR completes work on modernizing the Fortran MPI interface in QUICK to be compatible with Fortran 2008 standards. Specifically, the PR switches from using the mpi module to the mpi_f08 module and updates the relevent MPI types accordingly.

Notes / Limitations:

  • This PR does not address issues with MPI-specific source files being included for building non-MPI targets (i..e, serial, GPU versions of QUICK). To rectify this issue, the Makefile/CMake build systems need to define separate lists of source files for the MPI and non-MPI targets. Moreover, hacks in the source code for conditionally compiling MPI-specific portions of code need to be removed (e.g., lines similar to #ifdef MPIV surrounding MPI datatypes).

Closes #316.

@ohearnk ohearnk changed the title Mpi fortran module modernization 2 MPI Fortran Modernization Part 2 Mar 2, 2025
@ohearnk ohearnk requested a review from agoetz March 2, 2025 16:56
@ohearnk ohearnk self-assigned this Mar 2, 2025
@ohearnk ohearnk added the Code cleanup Code cleanup or refactoring label Mar 2, 2025
@ohearnk ohearnk force-pushed the mpi-fortran-module-modernization-2 branch from 22450f2 to aa37d67 Compare April 7, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code cleanup Code cleanup or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Fortran MPI support
1 participant