Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update memfault sdk to 1.19.0 #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: update memfault sdk to 1.19.0 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions applications/asset_tracker_v2/configuration/memfault/memfault_platform_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#pragma once

Check failure on line 1 in applications/asset_tracker_v2/configuration/memfault/memfault_platform_config.h

View workflow job for this annotation

GitHub Actions / call-workflow / Run license checks on patch series (PR)

License Problem 

Missing license information is not allowed for this file.

/*
* Platform overrides for the default configuration settings in the
Expand All @@ -7,7 +7,5 @@
*/

#if defined(CONFIG_DEBUG_MODULE)
/* Prepare captured metric data for upload to Memfault cloud every configured interval. */
#define MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS CONFIG_DEBUG_MODULE_MEMFAULT_HEARTBEAT_INTERVAL_SEC
#define MEMFAULT_DATA_EXPORT_CHUNK_MAX_LEN CONFIG_DEBUG_MODULE_MEMFAULT_CHUNK_SIZE_MAX
#endif /* defined(CONFIG_DEBUG_MODULE) */
5 changes: 0 additions & 5 deletions applications/asset_tracker_v2/doc/debug_module.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ Configuration options
CONFIG_DEBUG_MODULE_MEMFAULT_USE_EXTERNAL_TRANSPORT - Configuration for transfer of Memfault data
This option, if enabled, makes the debug module trigger events carrying Memfault data. This data can be routed through an external transport to Memfault cloud, for example, through AWS IoT, Azure IoT Hub, or `nRF Cloud`_.

.. _CONFIG_DEBUG_MODULE_MEMFAULT_HEARTBEAT_INTERVAL_SEC:

CONFIG_DEBUG_MODULE_MEMFAULT_HEARTBEAT_INTERVAL_SEC - Configuration for nRF Connect SDK Memfault metrics tracking interval
This option sets the time interval for tracking |NCS| Memfault metrics.

.. _CONFIG_DEBUG_MODULE_MEMFAULT_CHUNK_SIZE_MAX:

CONFIG_DEBUG_MODULE_MEMFAULT_CHUNK_SIZE_MAX - Configuration for maximum size of transmitted packets
Expand Down
4 changes: 4 additions & 0 deletions applications/asset_tracker_v2/overlay-memfault.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ CONFIG_MEMFAULT_NCS_STACK_METRICS=y
CONFIG_MEMFAULT_NCS_LOCATION_METRICS=y
CONFIG_MEMFAULT_LOGGING_ENABLE=y

# Configuration that sets how often Memfault captures and prepares data that will be sent
# to Memfault cloud. Reduced from the default 1 hour interval here for demonstration.
CONFIG_MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS=1800

CONFIG_MEMFAULT_ROOT_CERT_STORAGE_NRF9160_MODEM=y
# There is a race with the credential provisioning and starting LTE network search if automatic
# provisioning is used. Therefore it's disabled, and the app controls it.
Expand Down
10 changes: 0 additions & 10 deletions applications/asset_tracker_v2/src/modules/Kconfig.debug_module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,6 @@ config DEBUG_MODULE_MEMFAULT_USE_EXTERNAL_TRANSPORT
The AWS IoT configuration of the application is the only implementation that currently
supports this option.

config DEBUG_MODULE_MEMFAULT_HEARTBEAT_INTERVAL_SEC
int "Memfault heartbeat interval in seconds"
default 1800
help
Configuration that sets how often Memfault captures and prepares data that will be sent
to Memfault cloud. Reduce this interval to get more frequent updates to Memfault.
Note that data transmitted to Memfault cloud is still dependent on how often the
application sends data, which can be manipulated by setting the application's real-time
configurations.

config DEBUG_MODULE_MEMFAULT_WATCHDOG_DELTA_MS
int "Memfault software watchdog delta"
default 5000
Expand Down
1 change: 0 additions & 1 deletion samples/bluetooth/peripheral_mds/memfault_config/memfault_platform_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@
* "<NCS folder>/modules/lib/memfault-firmware-sdk/components/include/memfault/default_config.h"
*/

/* #define MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS 1800 */
7 changes: 0 additions & 7 deletions samples/debug/memfault/config/memfault_platform_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,3 @@
* "<NCS folder>/modules/lib/memfault-firmware-sdk/components/include/memfault/default_config.h"
*/

/* Uncomment the definition below to override the default setting for
* heartbeat interval. This will prepare the captured metric data for upload
* to Memfault cloud at the specified interval.
*/
/*
* #define MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS 1800
*/
2 changes: 1 addition & 1 deletion west.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ manifest:
remote: throwtheswitch
- name: memfault-firmware-sdk
path: modules/lib/memfault-firmware-sdk
revision: 1.12.0
revision: 1.19.0
remote: memfault
- name: bsim
repo-path: bsim_west
Expand Down
Loading