Add Wasm return_call demo #36288
Merged
Add Wasm return_call demo #36288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:wasm
|
Preview URLs (comment last updated: 2024-11-18 15:35:17) |
Comment on lines
9
to
10
| **`call`** calls a function, while **`call_indirect`** calls a function in a table. | ||
| **`return_call`** and **`return_call_indirect`** are the tail-call versions of `call` and `call_indirect`, respectively. |
There was a problem hiding this comment.
I appreciate that this predates you, but what is a tail-call? We should say, if you know?
It would be good to have an example of using call_indirect.
hamishwillee
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
@pepelsbey I've subedited to what I think is improved structure. I'd like an explanation of tail call ideally as per https://github.com/mdn/content/pull/36288/files#r1796238648
However if you don't want to do that because you consider it out of scope that is understandable - I'm approving so you have the choice to self merge.
|
@pepelsbey ^^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Part of the Firefox 121 release notes task that got delayed due to the platform’s lack of support.
Additional details