-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove automatic building in favor of just testing build completion #30
Conversation
Is this ready for review? |
too many downsides to having this run on PRs and if it doesn't then there's no validation of submissions.
Is is now! It's now pretty much like the old action but targets node20. |
So, does it create a PR for auto-building now? |
No, although I'm willing to rework this to retain that feature if you'd prefer. |
So, for future contributors, would we need to build before committing? |
It does not create a PR at all. |
I think it's best this way... |
The build/test action was failing for new PRs and new releases (since these both target commits rather than branches). It was also doing un-needed extra work by submitting the PR three times (because of the multi-platform strategy). Sorry I didn't catch this in my prior commit.