PLAT-25704: Add megabridge login flows #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
Jun 29, 2024
tulir
reviewed
Jun 30, 2024
|
I rolled back the gorilla update (and the other spurious package updates), unsure why the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the login flows for both Facebook and Instagram. Also fixes some bugs left behind from the last PR.
Note that it doesn't save the results of the login anywhere, will leave that for the next PR.
Note to reviewer: I still need help with the whole
example-config.ymlthing, it appears to override whatever is in config.yaml no matter what I do? In any case doesn't really affect anything right now.Also closes PLAT-25705 because it implements proper selection between facebook and instagram bridge modes, and allows using both at once.