crypto/ssss: only accept secret shares from verified devices #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradtgmurray
commented
Feb 12, 2025
| @@ -173,6 +173,22 @@ func (mach *OlmMachine) receiveSecret(ctx context.Context, evt *DecryptedOlmEven | |||
| return | |||
| } | |||
|
|
|||
| // https://spec.matrix.org/v1.10/client-server-api/#msecretsend | |||
| // "The recipient must ensure... that the device is a verified device owned by the recipient" | |||
| if senderDevice, err := mach.GetOrFetchDevice(ctx, evt.Sender, evt.SenderDevice); err != nil { | |||
There was a problem hiding this comment.
Hrm, should I GetOrFetchDevice here or just look in the local store?
The key backup signature checking only looks in the local store
Line 84 in 100d945
There was a problem hiding this comment.
It should always have the list cached, so shouldn't make a difference either way. If your own device list is somehow missing, it's probably only good that /sync is blocked until the list is fetched
tulir
changed the title
tulir
reviewed
Feb 13, 2025
tulir
approved these changes
Feb 13, 2025
bradtgmurray
deleted the
only-accept-secret-shares-from-verified-devices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.