Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages with breaking changes #133

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

Roaa94
Copy link
Contributor

@Roaa94 Roaa94 commented Nov 20, 2023

  • Update packages that had breaking changes:
    • The file_selector package replaces getSavePath with getSaveLocation.
    • The image package's fromBytes method uses named parameters and takes a ByteBuffer instead of Uint8List.
    • The fast_noise package now has a separate PerlinFractalNoise class for perlin noise fractal implementation and the previous PerlinNoise is the base noise object that only accepts frequency (see this PR description for more details)

@matthew-carroll
Copy link
Owner

Hi @Roaa94 - I merged your other PR. Can you update with the latest code? Also, it looks like it would be best to break this PR down. The update for tests to use the new test view API should be obvious, so that would make an easy standalone PR. The other three changes will require more a look. Can you file each one of those independently?

@Roaa94 Roaa94 changed the title Update packages and SDK upper limit Update packages with breaking changes Mar 24, 2024
@Roaa94
Copy link
Contributor Author

Roaa94 commented Mar 24, 2024

Hi @matthew-carroll, thanks for merging my other PR. I have updated this one to only include updating packages with breaking changes. Let me know if you need me to break this down further. Also opened another PR (#134) for using the test view API.
Unfortunately, I had already tried but it doesn't seem possible to request a review from my end.

Copy link
Owner

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit 7c9c280 into matthew-carroll:main Mar 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants