Skip to content

Update deploy-k8s-aks.rst #7899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update deploy-k8s-aks.rst #7899

wants to merge 7 commits into from

Conversation

wiersgallak
Copy link
Contributor

Updates to formatting and simplification of instructions based on doc drafted

Summary

Ticket Link

Updates to formatting and simplification of instructions
@wiersgallak wiersgallak added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Apr 28, 2025
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 28658f5

@cwarnermm cwarnermm removed the 2: Editor Review Requires review by an editor label Apr 28, 2025
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 885c31e

Copy link

Newest code from mattermost has been published to preview environment for Git SHA e7367b8

Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just flagging two small things I noticed

Comment on lines 60 to 67
6. Configure Mattermost installation hostname and Ingress details. The AGIC add-on is used in the following example to show the ingress annotations required.
a. You can use any pre-installed Ingress Controller in your cluster as long as it supports Kubernetes Ingress and TLS termination.

.. code-block:: yaml

kubernetes.io/ingress.class: azure/application-gateway
appgw.ingress.kubernetes.io/ssl-redirect: "true"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting on the note addition looks a bit off
image. I'm not sure I'm familiar enough with RST to suggest the proper fix here. @cwarnermm any ideas?

Comment on lines 94 to 99
**Step 2: Upgrade Mattermost**
Upgrade Mattermost via your AKS cluster
---------------------------------------

1. Visit the ``Extensions + Applications`` section of your AKS cluster where your Mattermost installation is deployed.
2. You can enable minor version auto upgrades since these are not updating Mattermost version
3. Expand the ``Configurarion Settings`` table and add the below configuration and the version you want to install as a value.
3. Expand the ``Configuration Settings`` table and add the below configuration and the version you want to install as a value.

.. code::

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this "Upgrade Mattermost via your AKS cluster" heading is missing somehow, at least in the preview environment?
image

Copy link
Member

@cwarnermm cwarnermm Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - unfortunately, Sphinx doesn't support headings within tabbed content. I recommend bolding the subtitle instead. @wiersgallak - I'll commit an update to this PR to address this.

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 3aba45c

@@ -206,8 +206,7 @@ Create a file named ``mattermost-filestore-secret.yaml`` to store the credential

4. If you are using Amazon S3, it's recommended to enable server-side encryption (SSE) and SSL. Add the following environment variables to the ``mattermostEnv`` section:

TBD

<TBD>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickmisasi - Can you provide details for this docs gap, please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit with updates

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 516fe31

@wiersgallak wiersgallak requested a review from nickmisasi April 30, 2025 14:16
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 6e23a9c

@cwarnermm
Copy link
Member

@toninis - Looking forward to your review and feedback on this PR.

Copy link

Newest code from mattermost has been published to preview environment for Git SHA a1626fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Dev Review Requires review by a core commiter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants