-
Notifications
You must be signed in to change notification settings - Fork 599
Update deploy-k8s-aks.rst #7899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Updates to formatting and simplification of instructions
Newest code from mattermost has been published to preview environment for Git SHA 28658f5 |
Newest code from mattermost has been published to preview environment for Git SHA 885c31e |
Newest code from mattermost has been published to preview environment for Git SHA e7367b8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just flagging two small things I noticed
6. Configure Mattermost installation hostname and Ingress details. The AGIC add-on is used in the following example to show the ingress annotations required. | ||
a. You can use any pre-installed Ingress Controller in your cluster as long as it supports Kubernetes Ingress and TLS termination. | ||
|
||
.. code-block:: yaml | ||
|
||
kubernetes.io/ingress.class: azure/application-gateway | ||
appgw.ingress.kubernetes.io/ssl-redirect: "true" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting on the note addition looks a bit off
. I'm not sure I'm familiar enough with RST to suggest the proper fix here. @cwarnermm any ideas?
**Step 2: Upgrade Mattermost** | ||
Upgrade Mattermost via your AKS cluster | ||
--------------------------------------- | ||
|
||
1. Visit the ``Extensions + Applications`` section of your AKS cluster where your Mattermost installation is deployed. | ||
2. You can enable minor version auto upgrades since these are not updating Mattermost version | ||
3. Expand the ``Configurarion Settings`` table and add the below configuration and the version you want to install as a value. | ||
3. Expand the ``Configuration Settings`` table and add the below configuration and the version you want to install as a value. | ||
|
||
.. code:: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct - unfortunately, Sphinx doesn't support headings within tabbed content. I recommend bolding the subtitle instead. @wiersgallak - I'll commit an update to this PR to address this.
Newest code from mattermost has been published to preview environment for Git SHA 3aba45c |
@@ -206,8 +206,7 @@ Create a file named ``mattermost-filestore-secret.yaml`` to store the credential | |||
|
|||
4. If you are using Amazon S3, it's recommended to enable server-side encryption (SSE) and SSL. Add the following environment variables to the ``mattermostEnv`` section: | |||
|
|||
TBD | |||
|
|||
<TBD> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickmisasi - Can you provide details for this docs gap, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit with updates
Newest code from mattermost has been published to preview environment for Git SHA 516fe31 |
Newest code from mattermost has been published to preview environment for Git SHA 6e23a9c |
@toninis - Looking forward to your review and feedback on this PR. |
Newest code from mattermost has been published to preview environment for Git SHA a1626fe |
Updates to formatting and simplification of instructions based on doc drafted
Summary
Ticket Link