[NOT FOR MERGE] core-v24.7.1 #2231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"%err" is just printing the leaf message which is not useful. "{err:#}"
prints the whole stack trace, as desired.
(cherry picked from commit f529a45)
## What ❔ Add metrics for better observability ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. (cherry picked from commit 1e48cd9)
## What ❔ + Change `get_transaction_receipts` DAL method to fetch the contract address from the `events` table. + Add integration test that checks we return the correct contract address in the receipt of the transaction that deployed inner-outer contract(e.g. contract that initializes another contract in its constructor). ## Why ❔ The current approach(going to the `storage_logs` table to get the contract address) is error-prone. The problem here is that we deduplicate storage logs, which renders operation_number invalid. So, the ordering is not correct, and we might return the incorrect deployed address. This is important when one tx deploys a contract that initializes another contract in the constructor(which means we deploy several contracts here) - the user expects the "outer" contract address but gets the inner. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. (cherry picked from commit 64cb269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.