Remove usage of legacy crypto in embedded.ts
#4668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface of `encryptAndSendToDevices` changes because `DeviceInfo` is from the legacy crypto. In fact `encryptAndSendToDevices` only need pairs of userId and deviceId.
florianduros
changed the title
embedded.spec.tsembedded.spec.ts
florianduros
requested review from
t3chguy and
MidhunSureshR
and removed request for
a team
|
I think this needs review from voip as they are the codeowners for it |
florianduros
requested review from
a team and
AndrewFerr
and removed request for
a team
florianduros
changed the title
embedded.spec.tsembedded.ts
florianduros
commented
Jan 31, 2025
| @@ -128,6 +137,7 @@ export enum RoomWidgetClientEvent { | |||
| PendingEventsChanged = "PendingEvent.pendingEventsChanged", | |||
| } | |||
| export type EventHandlerMap = { [RoomWidgetClientEvent.PendingEventsChanged]: () => void }; | |||
|
|
|||
There was a problem hiding this comment.
Noisy, I'll remove it
hughns
approved these changes
Jan 31, 2025
florianduros
merged commit 0185f30
into
florianduros/rip-out-legacy-crypto/remove-legacy-crypto
47 of 51 checks passed
florianduros
deleted the
florianduros/rip-out-legacy-crypto/clean-up-embedded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task element-hq/element-web#26922
Part of #4653
The interface of
encryptAndSendToDeviceschanges becauseDeviceInfois from the legacy crypto. In factencryptAndSendToDevicesonly need pairs ofuserIdanddeviceId.We need to update the interface and we can simplify it.
The CI is in failure because the root branch (which is a feature branch) has removed deprecated
MatrixClientmethods used by the legacy crypto. Legacy crypto which will be removed in this feature branch.