-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use black as code formatter #188
Conversation
For easier review: manual changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks 95% good, just needs a little manual work for the argparse code.
That's because black broke the line, and the |
Integrated into pyproject.toml and tests/test_code.py so we can enforce the formatting in the CI. Fixes martinpitt#187
fixed the pylint error with a follow-up to make it unnecessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers! Assuming green, this looks good. I'll change the max line length for the other tools as a follow-up.
arguably we should leave them as-is. Black will format the lines to 118 and enforce that, if you leave pylint/ruff on 130 (or remove the line length) then we can format with a trailing gah. fixed now (friday evening here, I probably shouldn't be pushing things :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers! Green 🍀 is the new black! 🏴
Now off to enabling black in vim 😁 |
Integrated into pyproject.toml and tests/test_code.py so we can enforce the formatting in the CI.
Fixes #187
Quick! let's do this before someone has an idea of refactoring everything :)