Standalone updates #450
Merged
Standalone updates #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. use nf-config instead of nc-config if available 2. add "-g" to gfortran compile flags 3. remove spurious comment
Besides marking failed tests with an asterisk, also provide a list of all failed tests (there are so many tests now it's challenging to scroll back through and look for the *s)
s With baselines from an intel chip, the Apple M2 chip was failing several of the netCDF Comparison tests; increasing the relative tolerance to 1e-9 lets those comparisons pass. This will be more useful if we need to update the baselines in the future, since the easiest machine to generate baselines on is my laptop (with an M2) but the continuous integration is run on a github machine with an intel or amd chip.
All tests pass on derecho (need to be on compute node for mpi test); I recommend the develop queue with 1 node and 2 cores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to the standalone driver to make sure all tests pass on an M2 Mac laptop and on derecho