Skip to content

Commit

Permalink
Merge pull request #467 from manala/lazy.symfony/node-versions
Browse files Browse the repository at this point in the history
[Lazy - Symfony] Add missing Node versions
  • Loading branch information
ogizanagi authored Nov 18, 2024
2 parents 5013584 + 7057a2a commit e721719
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lazy.symfony/.manala.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ system:
extensions: []
nodejs:
# @option {"label": "Nodejs version"}
# @schema {"enum": [null, 16, 14, 12]}
# @schema {"enum": [null, 22, 20, 18, 16, 14, 12]}
version: ~
mariadb:
# @option {"label": "MariaDB version"}
Expand Down
9 changes: 9 additions & 0 deletions lazy.symfony/.manala/docker/Dockerfile.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,21 @@ Signed-By: /etc/apt/keyrings/sury_php.gpg\n\
{{ if $nodejs.version -}}
# Nodejs
RUN \
{{- if semverCompare "<=20" ($nodejs.version | toString) }}
curl -sSLf https://deb.nodesource.com/gpgkey/nodesource.gpg.key \
--output /etc/apt/keyrings/nodesource.asc \
{{- else }}
curl -sSLf https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key \
--output /etc/apt/keyrings/nodesource.asc \
{{- end }}
&& printf "\
Types: deb\n\
URIs: https://deb.nodesource.com/node_{{ $nodejs.version }}.x\n\
{{- if semverCompare "<=20" ($nodejs.version | toString) }}
Suites: {{ include "os_release" "VERSION_CODENAME" }}\n\
{{- else }}
Suites: nodistro\n\
{{- end }}
Components: main\n\
Signed-By: /etc/apt/keyrings/nodesource.asc\n\
" > /etc/apt/sources.list.d/nodesource.sources \
Expand Down
2 changes: 1 addition & 1 deletion lazy.symfony/test/.manala.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ system:
extensions:
- bcmath
nodejs:
version: 16
version: 22
mariadb:
version: 10.5
phpmyadmin:
Expand Down

0 comments on commit e721719

Please sign in to comment.