Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cs cannot be built on Armbian, so let's not depend on it #288

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

attilabody
Copy link
Contributor

@attilabody attilabody commented Jan 25, 2025

Armbian on Raspberry Pi is missing liblivemedia(-dev) and libcamera-apps-lite, so camera-streamer cannot be installed, but starting crowsnest fails due to the missing camera-streamer dependency.

@mryel00
Copy link
Member

mryel00 commented Jan 26, 2025

Please give some detail on what exactly your setup is. Are you using armbian on a Raspberry Pi?

Copy link
Member

@mryel00 mryel00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change back all the formatting you have changed. You did not add 168 lines and deleted 131, you just added ~25 lines.
If you want to format code, do this in a separate PR, but not in a bug PR, with a completely different topic.

@attilabody
Copy link
Contributor Author

Please give some detail on what exactly your setup is. Are you using armbian on a Raspberry Pi?

Yes, Armbian on RPi (mainly for the easy way for BTRFS root and consistency with my other printers with non-RPi boards)

@attilabody
Copy link
Contributor Author

attilabody commented Jan 30, 2025

Please change back all the formatting you have changed. You did not add 168 lines and deleted 131, you just added ~25 lines. If you want to format code, do this in a separate PR, but not in a bug PR, with a completely different topic.

It should have been some automated reformatter. I will look into it.

@mryel00
Copy link
Member

mryel00 commented Jan 30, 2025

Thanks for everything 😄
One last request, can you send the output of /etc/os-release for documentation reasons?

@mryel00 mryel00 changed the base branch from master to develop January 30, 2025 13:33
@attilabody
Copy link
Contributor Author

klipper@frankencube:~$ cat /etc/os-release 
PRETTY_NAME="Armbian-unofficial 25.02.0-trunk bookworm"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.armbian.com"
SUPPORT_URL="https://forum.armbian.com"
BUG_REPORT_URL="https://www.armbian.com/bugs"
ARMBIAN_PRETTY_NAME="Armbian-unofficial 25.02.0-trunk bookworm"

@mryel00
Copy link
Member

mryel00 commented Jan 30, 2025

As this is an unofficial image, I flashed an official real quick, to compare the output:

PRETTY_NAME="Armbian 24.11.1 bookworm"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.armbian.com"
SUPPORT_URL="https://forum.armbian.com"
BUG_REPORT_URL="https://www.armbian.com/bugs"
ARMBIAN_PRETTY_NAME="Armbian 24.11.1 bookworm"

@mryel00 mryel00 merged commit acee8b3 into mainsail-crew:develop Jan 30, 2025
1 check passed
@mryel00
Copy link
Member

mryel00 commented Jan 30, 2025

Thanks for the contribution 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants