-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgradable Earner Manager #86
Conversation
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
LCOV of commit
|
8897271
to
17e958f
Compare
5594ab2
to
5865343
Compare
5865343
to
65c3df9
Compare
65c3df9
to
ab3194a
Compare
ab3194a
to
e22f3fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
One remaining logical puzzle to think through (left comments):
- situation when address was admin owner first, but later was also added to TTG is not clear.
- admin won't be able to release this account and will get % of fee
An admin will not get a fee for an account added to the registrar because the earner manager returns a zero fee rate and a zero admin for any account that's already in the registrar, regardless if it was originally added via an admin. |
91e7f83
to
596cd79
Compare
* feat: Upgradable Earner Manager
No description provided.