-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trait-db v0 #722
Merged
Merged
Trait-db v0 #722
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
ed3caab
laji-api-client prototype
Blodir 1310fc0
Merge branch 'development' into api-client-prototype
Blodir 968ebb5
init trait-db and api-client
Blodir b145543
fix infinite loading when logged out
Blodir 23058c3
trait-db about page
Blodir a8aa5a8
trait-db new dataset
Blodir b2b8f62
use OnPush to trait-db components
Blodir 791f29e
traits index page
Blodir 435c5c6
trait-db single trait view
Blodir 298eb83
trait-db new trait and new dataset fields
Blodir 2d9d841
Merge branch 'development' into trait-db-186748322
Blodir 1727de1
trait-db edit dataset
Blodir 7f249e4
trait-db indicate deletion of datasets
Blodir d4632a8
Merge branch 'development' into trait-db-186748322
Blodir a07e766
automatic cache flushing
Blodir b92d5ec
new laji-ui datatable component
Blodir b78d3bd
trait-db-browse use lu-datatable
Blodir 1b55d19
lu-datatable improvements
Blodir ee2cc17
lu-datatable custom cell templates
Blodir aea5345
remove console.log
Blodir 9ce4692
sortable should default to true
Blodir 4bb40c2
sorting should support default columns with custom sortfn
Blodir fca56a6
paginator active styles
Blodir 72a6600
improve scroll css and default ghost size
Blodir 58b982a
separate trait search from the trait browser page
dbe6753
update schema
Blodir 0a97ef0
cache in-progress observables
Blodir 6e91048
make datatable y-scrollable
Blodir ba52d01
update swagger
Blodir 4ae3ad0
trait-db trait-search-filters
Blodir 44eb2ff
get datasets and traits from api
Blodir a50180b
trait-search additional filters
Blodir c5c9285
trait-search should not know about internal structure of additional-f…
Blodir 56a60ae
additional filters styling
Blodir fe16081
remove redundant dep
Blodir ab626b2
update readme & remove redundant setter for base url
Blodir 80194de
move datatable example
Blodir 3dc7c3c
remove redundant var
Blodir 2162228
clear filters btn
Blodir dfafa67
hide trait-db in prod
Blodir 845eb79
Merge branch 'development' into trait-db-186748322
Blodir fa1f1ea
strict typing
Blodir e886405
fix lint
Blodir b91502d
fix laji-api-client base url
Blodir 89b7185
remove redundant style
Blodir ba83865
allow column templates to use prop
Blodir bd0990b
check that defaultColumns isnt null
Blodir 0d57a41
extract datatable paginator into its own component
Blodir 75c6c1b
rename new-dataset to dataset-editor
Blodir 2d29dc3
tighten parameter type bounds
Blodir cdb255a
provide baseurl as an injection token
Blodir a487661
update hash
Blodir 0070807
variable level path caching
Blodir 0226bd8
split path vars separately from proceeding path
Blodir ef2496e
remove trait-db link from beta
Blodir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
Updating api type definitions: | ||
|
||
``` | ||
npm i | ||
|
||
// update types based on the new API openapi schema | ||
npm run updateNew | ||
``` | ||
|
||
Usage: | ||
```typescript | ||
export class ExampleComponent { | ||
constructor(private lajiApiClientService: LajiApiClientBService) {} | ||
function f() { | ||
const a$ = this.lajiApiClientService.fetch('/collections', 'get', { query: { page: 1 } }); | ||
} | ||
} | ||
``` | ||
|
||
Queries are cached by default based on the path and the query params. Whenever a new non-get request is sent to the same path, the cache is flushed automatically. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is out of date. If it's hard to document, maybe put a link to the review discussion that explains it? Or just remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or idk... it's not entirely out of date. It says "based on the path", which is correct. I mean it doesn't mention that the path params affect it also. Maybe we can update the README after we develop the other changes (like method wrappers
get()
put()
etc)