Update row order id, so last rows always delete #212 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current patch only against this version. Haven't updated to the latest dev / rc because there seems to be some back and forth. Issue https://www.drupal.org/project/tablefield/issues/3441319 has branch that's up to date for dev.
ekes
requested review from
finnlewis and
markconroy
and removed request for
finnlewis
|
Hey @ekes, do you know if tablefield 3.x is also affected? Just thinking for the D11 work we upgrade from 2.x to 3.x so we'll need to do a test there as well |
|
Didn't test that one. Just the current release, and 2.x dev. |
|
👍 I'll give it a quick test the next time I start up the D11 project |
|
I'll test this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current patch only against this version. Haven't updated to the latest dev / rc because there seems to be some back and forth. Issue https://www.drupal.org/project/tablefield/issues/3441319 has branch that's up to date for dev.
What does this change?
Presently when a table has had its rows moved around the internal stored row order isn't in sync. So when you delete rows the rows that were at the bottem get deleted. Patch - see issue - fixes this.
How to test
Create some content with a paragraph table. Add rows "1", "2", "3", "4". Move "4" to be second row. 'Change number of rows/columns' to remove a row and 'Rebuild table'. Without patch "4" (now second row) is removed. With patch "3" (now forth row) will be removed.