[AMDGPU] Change CWD from within tmp directory #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in llvm#402 the former solution deleted the CWD from within that directory, rendering the state quite useless and resulting in errors on execution. The approach in here creates a temp directory, changes to it, removes the old CWD, recreates it, and changes back to that directory. I opted for this solution as, oddly enough, I had some trouble removing the enumerated list of files in the buildtree.
jhuber6
approved these changes
Mar 4, 2025
|
One could also have deleted all the contents of the directory, instead the directory itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #402 the former solution deleted the CWD from within that directory, rendering the state quite useless and resulting in errors on execution.
The approach in here creates a temp directory, changes to it, removes the old CWD, recreates it, and changes back to that directory. I opted for this solution as, oddly enough, I had some trouble removing the
enumerated list of files in the buildtree.