Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: PEP 621 @geminixiang #99

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Conversation

geminixiang
Copy link
Contributor

@geminixiang geminixiang commented Jan 6, 2025

Updated pyproject.toml to comply with the PEP 621 standard.

ref. https://python-poetry.org/docs/pyproject

@geminixiang geminixiang linked an issue Jan 6, 2025 that may be closed by this pull request
@geminixiang geminixiang self-assigned this Jan 6, 2025
@g8s-bot g8s-bot changed the title feat: PEP 621 ✨ feat: PEP 621 @geminixiang Jan 6, 2025
@geminixiang
Copy link
Contributor Author

geminixiang commented Jan 6, 2025

❯ GITHUB_TOKEN=SECRET GITHUB_REPOSITORY=livingbio/pr-lint PR_NUMBER=99 poetry
 run pr-lint
Updated PR title: feat: PEP 621 -> ✨ feat: PEP 621 @geminixiang

It works successfully locally, but it seems there are some issues that need to be resolved in the GitHub Actions environment.

@geminixiang geminixiang changed the title ✨ feat: PEP 621 @geminixiang feat: PEP 621 @geminixiang Jan 6, 2025
@geminixiang geminixiang force-pushed the 98-feat-add-support-for-poetry-2 branch from 26863af to 26fff7c Compare January 6, 2025 06:07
@github-actions github-actions bot changed the title feat: PEP 621 @geminixiang ✨ feat: PEP 621 @geminixiang Jan 6, 2025
@@ -10,7 +10,7 @@ jobs:

steps:
- id: pr-lint
uses: livingbio/pr-lint@main
uses: livingbio/pr-lint@98-feat-add-support-for-poetry-2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh~ an error occurred when the CI ran the main branch code

Copy link
Contributor Author

@geminixiang geminixiang Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucemia 這邊 CI 臨時改使用本 PR code ,就正確了,
只為驗證 pr-lint 正確,跟本次 PR 無關,所以後續改回 main

This reverts commit 4865f63.
@geminixiang geminixiang marked this pull request as ready for review January 6, 2025 06:13
@geminixiang geminixiang requested a review from lucemia January 6, 2025 06:13
@@ -20,7 +20,7 @@ runs:
python-version: "3.x"

- name: Install pr-lint
run: pip install poetry && poetry install
run: pip install poetry && poetry sync
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme = "README.md"

[project.scripts]
pr-lint = "pr_lint.main:app"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geminixiang geminixiang merged commit c27cd2d into main Jan 6, 2025
2 checks passed
@geminixiang geminixiang deleted the 98-feat-add-support-for-poetry-2 branch January 6, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: add support for poetry 2.0.0
2 participants