feat: Support blackhole, prohibit and unreachable route types #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangwen12year
changed the title
liangwen12year
force-pushed
the
route_type
branch
from
557c705 to
06ddc26
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 45.03% 45.00% -0.04%
==========================================
Files 12 12
Lines 3080 3100 +20
Branches 428 433 +5
==========================================
+ Hits 1387 1395 +8
- Misses 1692 1704 +12
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[citest] |
liangwen12year
force-pushed
the
route_type
branch
2 times, most recently
from
5a86e82 to
c3ba56e
Compare
|
[citest] |
liangwen12year
force-pushed
the
route_type
branch
from
c3ba56e to
f804f3a
Compare
|
[citest] |
liangwen12year
force-pushed
the
route_type
branch
from
f804f3a to
5e3cfcb
Compare
|
[citest] |
liangwen12year
force-pushed
the
route_type
branch
from
5e3cfcb to
86c18ec
Compare
|
[citest] |
|
[citest bad] |
richm
reviewed
Jan 5, 2024
liangwen12year
force-pushed
the
route_type
branch
2 times, most recently
from
464b417 to
1a4272c
Compare
|
[citest] |
tyll
reviewed
Jan 8, 2024
liangwen12year
force-pushed
the
route_type
branch
from
1a4272c to
3c75667
Compare
|
[citest] |
liangwen12year
force-pushed
the
route_type
branch
from
3c75667 to
1374583
Compare
|
[citest] |
richm
previously approved these changes
Jan 9, 2024
liangwen12year
force-pushed
the
route_type
branch
from
1374583 to
659adcb
Compare
liangwen12year
force-pushed
the
route_type
branch
3 times, most recently
from
020b651 to
f0e079b
Compare
|
@tyll , Thanks for the comments, I think that I addressed them all. |
liangwen12year
force-pushed
the
route_type
branch
from
f0e079b to
6ef4bc6
Compare
tyll
reviewed
Jan 10, 2024
liangwen12year
force-pushed
the
route_type
branch
2 times, most recently
from
982e400 to
667ced6
Compare
liangwen12year
changed the title
liangwen12year
force-pushed
the
route_type
branch
from
667ced6 to
51e1c03
Compare
|
[citest] |
tyll
reviewed
Jan 10, 2024
liangwen12year
force-pushed
the
route_type
branch
from
51e1c03 to
299790e
Compare
liangwen12year
changed the title
liangwen12year
force-pushed
the
route_type
branch
from
299790e to
2bbc284
Compare
|
[citest] |
liangwen12year
force-pushed
the
route_type
branch
from
2bbc284 to
b4e710d
Compare
|
[citest] |
tyll
reviewed
Jan 12, 2024
tyll
reviewed
Jan 12, 2024
|
Only minor remarks from me, I don't need to re-review this. I am fine with someone else approving this after the changes. |
liangwen12year
force-pushed
the
route_type
branch
from
b4e710d to
0b08def
Compare
|
[citest] |
It is useful and common practice to configure the routes with blackhole, prohibit, and unreachable route types when users have BGP routing setups. Notice that this feature is only for nm provider using `network_connections` variable. Configuring blackhole, prohibit, and unreachable route types is also supported by using `network_state` since nmstate version 2.2.20 (the setting name is `route-type`). Resolves: https://issues.redhat.com/browse/RHEL-19579 Signed-off-by: Wen Liang <liangwen12year@gmail.com>
liangwen12year
force-pushed
the
route_type
branch
from
0b08def to
cc592c2
Compare
|
[citest] |
richm
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users have BGP routing setups, it is common practice to blackhole some less-specific routes in order to avoid routing loops, and the BGP router might insert a more specific route dynamically afterwards.
Enhancement:
Reason:
Result:
Issue Tracker Tickets (Jira or BZ if any):