Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7510] - Cypress tests for Databases create page for restricted users #11912

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

dmcintyr-akamai
Copy link
Contributor

Description 📝

Add Cypress tests for Databases create page for restricted users

How to test 🧪

pnpm cy:e2e -s "cypress/e2e/core/databases/create-database.spec.ts"

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Commit message and pull request title format standards

Note: Remove this section before opening the pull request
Make sure your PR title and commit message on squash and merge are as shown below

<commit type>: [JIRA-ticket-number] - <description>

Commit Types:

  • feat: New feature for the user (not a part of the code, or ci, ...).
  • fix: Bugfix for the user (not a fix to build something, ...).
  • change: Modifying an existing visual UI instance. Such as a component or a feature.
  • refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.
  • test: New tests or changes to existing tests. Does not change the production code.
  • upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.

Example: feat: [M3-1234] - Allow user to view their login history


Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@dmcintyr-akamai dmcintyr-akamai marked this pull request as ready for review March 24, 2025 17:56
@dmcintyr-akamai dmcintyr-akamai requested review from a team as code owners March 24, 2025 17:56
@dmcintyr-akamai dmcintyr-akamai requested review from jdamore-linode, bnussman-akamai, hasyed-akamai and cliu-akamai and removed request for a team March 24, 2025 17:56
@bnussman-akamai bnussman-akamai changed the title test [M3-7510]: Cypress tests for Databases create page for restricted users test: [M3-7510] - Cypress tests for Databases create page for restricted users Mar 24, 2025
Copy link
Contributor

@hasyed-akamai hasyed-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmcintyr-akamai, apart from only checking the Button to be disable with tooltip Text we can also check for the resource section to be available similar to be this and check there is no presence of table for the database for empty state similar to this

  • Also for the restricted user Access are we planning for the non-empty state as well reference as this is also a use case in which we need to check that the action menu buttons should also be disabled when having read-only access which is implemented recently in the PR ?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing529 Passing4 Skipped109m 38s

Details

Failing Tests
SpecTest
placement-groups-linode-assignment.spec.tsPlacement Groups Linode assignment » can assign non-compliant Linode with flexible placement group policy

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/placementGroups/placement-groups-linode-assignment.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants