Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix styling for Linode Entity Details body and footer #11907

Closed

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Mar 21, 2025

going to close this + reopen a new PR branching off of the release branch

Description 📝

  • some padding/margins seem off for Linode entity details vs prod, potentially another regression from MUIv6. I tried fixing them to make it look like prod again ... hopefully!

No changeset needed - this hasn't hit prod yet
Potentially worth updating / simplifying styles for entity details one day

Target release date 🗓️

3/25

Preview 📷

large small screen
prod image image
before image image
after image image

How to test 🧪

Reproduction steps

  • check out develop
  • notice styling for Linode entity detail

Verification steps

  • Confirm styling is fixed
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@coliu-akamai coliu-akamai added the Bug Fixes for regressions or bugs label Mar 21, 2025
@coliu-akamai coliu-akamai self-assigned this Mar 21, 2025
@coliu-akamai coliu-akamai marked this pull request as ready for review March 21, 2025 20:02
@coliu-akamai coliu-akamai requested a review from a team as a code owner March 21, 2025 20:02
@coliu-akamai coliu-akamai requested review from dwiley-akamai and cliu-akamai and removed request for a team March 21, 2025 20:02
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 539 passing tests on test run #1 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing539 Passing3 Skipped136m 8s

@coliu-akamai coliu-akamai changed the base branch from staging to release-v1.138.0 March 24, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants