upcoming: [M3-9090] - Update existing v4/linodes/instances endpoints and types for Linode Interfaces project
#11566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
force-pushed
the
m3-9090
branch
3 times, most recently
from
856ac57 to
f99c3b9
Compare
coliu-akamai
commented
Jan 28, 2025
packages/manager/cypress/e2e/core/linodes/linode-config.spec.ts
Outdated
Show resolved
Hide resolved
coliu-akamai
commented
Jan 28, 2025
coliu-akamai
requested review from
dmcintyr-akamai,
carrillo-erik,
abailly-akamai and
bnussman-akamai
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Jan 29, 2025
coliu-akamai
added
Add'tl Approval Needed
packages/manager/src/utilities/codesnippets/generate-terraformConfig.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/utilities/codesnippets/generate-pythonSDKSnippet.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/linodes/linode-config.spec.ts
Outdated
Show resolved
Hide resolved
coliu-akamai
commented
Feb 3, 2025
|
going to be testing out another approach - marking this as a draft for now 🙏 |
coliu-akamai
commented
Feb 4, 2025
Comment on lines
-34
to
-35
| // @TODO Linode Interfaces - follow up on if FirewallTemplate rules have the fingerprint / version fields. | ||
| // FirewallRules do, but the objects returned from the getFirewallTemplate requests don't |
There was a problem hiding this comment.
removed this comment bc it was answered in the spec (see [M3-9210] a list of api questions we're monitoring)
bnussman-akamai
approved these changes
Feb 4, 2025
abailly-akamai
approved these changes
Feb 5, 2025
| * must be created in a region that supports the new interfaces. | ||
| * | ||
| * Default value on depends on interfaces_for_new_linodes field in AccountSettings object. | ||
| */ |
| return ( | ||
| interfaces === undefined || | ||
| interfaces.length === 0 || | ||
| interfaces.some((iface) => 'purpose' in iface) |
There was a problem hiding this comment.
'purpose' in iface - this made me smile
packages/manager/src/features/Linodes/LinodeEntityDetailHeader.tsx
Outdated
Show resolved
Hide resolved
bnussman-akamai
added
Approved
carrillo-erik
approved these changes
Feb 5, 2025
Cloud Manager UI test results🔺 1 failing test on test run #26 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts" |
|||||||||||||||||
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 34m 05s |
| Commit |
|
| Committer | Connie Liu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
6
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
500
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅