Fixed a bug where the default setting for DNS over TCP was unintentionally disabled #6202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nally disabled. Motivation: DNS over TCP configuration should be enabled by default for DNS resolvers. The default setting was disabled while line#6127 was implemented. Motifications: - Revert the default settings for TCP fallback to enable by default. Result: The default DNS resolver correctly performs TCP fallback.
ikhoon
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6202 +/- ##
============================================
+ Coverage 74.46% 74.57% +0.11%
- Complexity 22234 22384 +150
============================================
Files 1963 1969 +6
Lines 82437 82799 +362
Branches 10764 10789 +25
============================================
+ Hits 61385 61751 +366
+ Misses 15918 15911 -7
- Partials 5134 5137 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jrhee17
approved these changes
Apr 10, 2025
|
Thanks, @ikhoon! |
minwoox
pushed a commit
that referenced
this pull request
Apr 15, 2025
…nally disabled (#6202) Motivation: DNS over TCP configuration should be enabled by default in DNS resolvers. However, the default setting was unintentionally disabled during the implementation of #6127. Motifications: - Revert the default settings to re-enable TCP fallback in DNS resolver. Result: The default DNS resolver now correctly performs TCP fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
DNS over TCP configuration should be enabled by default in DNS resolvers. However, the default setting was unintentionally disabled during the implementation of #6127.
Motifications:
Result:
The default DNS resolver now correctly performs TCP fallback.