Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #6125

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Update dependencies #6125

merged 4 commits into from
Mar 4, 2025

Conversation

minwoox
Copy link
Contributor

@minwoox minwoox commented Feb 25, 2025 •
edited
Loading

  • Apache Client 5.4.1 -> 5.4.2
  • BlockHound 1.0.10.RELEASE -> 1.0.11.RELEASE
  • Brave 6.0.3 -> 6.1.0
  • Brotli4J 1.17.0 -> 1.18.0
  • Context Propagation 1.1.1 -> 1.1.2
  • ControlPlane 1.0.46 -> 1.0.48
  • GraphQL Kotlin 8.2.1 -> 8.3.0
  • gRPC Java 1.68.1 -> 1.70.0
  • Guava 33.3.1-jre -> 33.4.0-jre
  • Jackson 2.18.1 -> 2.18.2
  • JSoup 1.18.1 -> 1.18.3
  • Kafka 3.8.1 -> 3.9.0
  • Kotlin 1.9.25 -> 2.1.10
  • Kotlin Coroutine 1.9.0 -> 1.10.1
  • Kubernetes Client 6.13.4 -> 6.13.5
  • Logback 1.5.12 -> 1.5.16
  • Micrometer 1.13.6 -> 1.14.4
  • Micrometer Tracing 1.3.5 -> 1.4.3
  • Netty 4.1.115.Final -> 4.1.118.Final
  • Netty Incubator IO_Uring 0.0.25.Final -> 0.0.26.Final
  • Prometheus 1.3.2 -> 1.3.6
  • Protobuf Jackson 2.6.0 -> 2.7.0
  • Reactor 3.6.11 -> 3.7.3
  • Resilience4J 2.2.0 -> 2.3.0
  • RxJava 3.1.9 -> 3.1.10
  • Sangria 4.2.2 -> 4.2.5
  • Scala213 2.13.15 -> 2.13.16
  • Spring6 6.2.3
  • Spring Boot 3.3.5 -> 3.4.3
  • Build and Test
    • AssertJ 3.26.3 -> 3.27.3
    • Awaitility 4.2.2 -> 4.3.0
    • Dagger 2.52 -> 2.53
    • Errorprone 2.35.1 -> 2.36.0
    • GAX gRPC 2.57.0 -> 2.61.0
    • Jakarta validation 3.1.0 -> 3.1.1
    • Java Websocket 1.5.7 -> 1.6.0
    • JKube 1.17.0 -> 1.18.1
    • jmh-gradle-plugin 0.7.2 -> 0.7.3
    • JUnit5 5.11.3 -> 5.12.0
    • JWT 4.4.0 -> 4.5.0
    • ktlint-gradle-plugin 12.1.1 -> 12.1.2
    • MUnit 1.0.2 -> 1.1.0
    • NullAway 0.12.1 -> 0.12.3
    • nullaway-gradle-plugin 2.1.0 -> 2.2.0
    • Test Containers 1.20.3 -> 1.20.5

@minwoox
Update dependencies
cc4d953 
- Apache Client 5.4.1 -> 5.4.2
- BlockHound 1.0.10.RELEASE -> 1.0.11.RELEASE
- Brave 6.0.3 -> 6.1.0
- Brotli4J 1.17.0 -> 1.18.0
- Context Propagation 1.1.1 -> 1.1.2
- ControlPlane 1.0.46 -> 1.0.48
- GraphQL Kotlin 8.2.1 -> 8.3.0
- gRPC Java 1.68.1 -> 1.70.0
- Guava 33.3.1-jre -> 33.4.0-jre
- Jackson 2.18.1 -> 2.18.2
- JSoup 1.18.1 -> 1.18.3
- Kafka 3.8.1 -> 3.9.0
- Kotlin 1.9.25 -> 2.1.10
- Kotlin Coroutine 1.9.0 -> 1.10.1
- Kubernetes Client 6.13.4 -> 7.1.0
- Logback 1.5.12 -> 1.5.16
- Micrometer 1.13.6 -> 1.14.4
- Micrometer Tracing 1.3.5 -> 1.4.3
- Netty 4.1.115.Final -> 4.1.118.Final
- Netty Incubator IO_Uring 0.0.25.Final -> 0.0.26.Final
- Prometheus 1.3.2 -> 1.3.6
- Protobuf Jackson 2.6.0 -> 2.7.0
- Reactor 3.6.11 -> 3.7.3
- Resilience4J 2.2.0 -> 2.3.0
- RxJava 3.1.9 -> 3.1.10
- Sangria 4.2.2 -> 4.2.5
- Scala213 2.13.15 -> 2.13.16
- Spring6 6.2.3
- Spring Boot 3.3.5 -> 3.4.3
- Build and Test
  - AssertJ 3.26.3 -> 3.27.3
  - Awaitility 4.2.2 -> 4.3.0
  - Dagger 2.52 -> 2.53
  - Errorprone 2.35.1 -> 2.36.0
  - GAX gRPC 2.57.0 -> 2.61.0
  - Jakarta validation 3.1.0 -> 3.1.1
  - Java Websocket 1.5.7 -> 1.6.0
  - JKube 1.17.0 -> 1.18.1
  - jmh-gradle-plugin 0.7.2 -> 0.7.3
  - JUnit5 5.11.3 -> 5.12.0
  - JWT 4.4.0 -> 4.5.0
  - ktlint-gradle-plugin 12.1.1 -> 12.1.2
  - MUnit 1.0.2 -> 1.1.0
  - NullAway 0.12.1 -> 0.12.3
  - nullaway-gradle-plugin 2.1.0 -> 2.2.0
  - Test Containers 1.20.3 -> 1.20.5
@minwoox minwoox added this to the 1.32.0 milestone Feb 25, 2025
@minwoox minwoox mentioned this pull request Feb 25, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

🔍 Build Scan® (commit: 2e48dd9)

Job name Status Build Scan®
build-ubicloud-standard-16-jdk-8 ✅ https://ge.armeria.dev/s/p4rmxnsvrh53m
build-ubicloud-standard-16-jdk-21-snapshot-blockhound ✅ https://ge.armeria.dev/s/6b7uziukafvcc
build-ubicloud-standard-16-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/43jugr2kd7ldo
build-ubicloud-standard-16-jdk-17-min-java-11 ✅ https://ge.armeria.dev/s/zhnf4behjzpuy
build-ubicloud-standard-16-jdk-17-leak ✅ https://ge.armeria.dev/s/a5wfszipeodzs
build-ubicloud-standard-16-jdk-11 ✅ https://ge.armeria.dev/s/r5t4ef26dfgzk
build-macos-latest-jdk-21 ✅ https://ge.armeria.dev/s/l7lf6lgdsuz5k

ikhoon
ikhoon reviewed Mar 4, 2025
View reviewed changes
grpc/src/main/java/com/linecorp/armeria/server/grpc/GrpcServiceBuilder.java Outdated
Comment on lines 449 to 452
final ServerServiceDefinition interceptV1 =
ServerInterceptors.intercept(ProtoReflectionServiceV1.newInstance(),
protoReflectionServiceInterceptor);
return addProtoReflectionIntercept(interceptV1, path, methodDescriptor);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question) Should both ProtoReflectionServiceV1 and ProtoReflectionService be set when ProtoReflectionService is specified by a user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the way I've implemented it. Do you have any concerns?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not very familiar with ProtoReflectionServiceV1. Could you explain why both are necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see! You were asking whether we need to provide both services when ProtoReflectionService is specified.
The answer is no, we don't have to. I only implemented it this way to include ProtoReflectionServiceV1 with a warning log for a smoother migration. If you think it's unnecessary, I can remove it—I'm fine with either approach. It's your call. 😉

Copy link
Contributor

@ikhoon ikhoon Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API is managed by gRPC-Java. Users should follow the library's policy. I believe it is up to the user which version of the API to use from the perspective of Armeria.

What do you think of setting the proto reflection service as it is instead of adding the new API automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big deal. Addressed.

ikhoon
ikhoon approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇‍♂️🙇‍♂️

@minwoox minwoox merged commit 80db754 into line:main Mar 4, 2025
14 checks passed
@minwoox minwoox deleted the update_deps branch March 4, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikhoon ikhoon ikhoon approved these changes

@jrhee17 jrhee17 jrhee17 approved these changes

@trustin trustin Awaiting requested review from trustin trustin is a code owner

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
1.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@minwoox @ikhoon @jrhee17