Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update send to address functionality #168

Merged
merged 39 commits into from
Jan 23, 2024
Merged

feat: update send to address functionality #168

merged 39 commits into from
Jan 23, 2024

Conversation

DNR500
Copy link
Contributor

@DNR500 DNR500 commented Dec 15, 2023 •
edited
Loading

Jira: LF-5322

This PR covers the updated Send to Wallet workflow and adds

  • Send to wallet page
  • Send to wallets bookmarks page
  • Send to wallets recent addresses page
  • Send to wallets connected wallets page
  • Store which persists the bookmarks and recent addresses locally
  • and provides some validation around the entry of addresses

Designs - https://www.figma.com/file/rGJrqtE7660rPUTrtS3yqR/Widget?type=design&node-id=15564-41521&mode=design&t=5f7bddsb8fGHa9fy-0

@DNR500 DNR500 added the WIP Work in progress label Dec 15, 2023
@DNR500 DNR500 force-pushed the send-to-wallet-ux-update branch 3 times, most recently from f25cc86 to afaaed8 Compare January 10, 2024 11:12
@DNR500 DNR500 force-pushed the send-to-wallet-ux-update branch from 353725f to 0a4bbdc Compare January 15, 2024 15:17
@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://8797c865.widget-sendtowall.pages.dev

Nathan Richards added 21 commits January 17, 2024 12:54
feat: introduce new ux flow for custom send to address functionality
094200a
feat: move functionality to match new design
31365b3
feat: add the bookmarked wallets section
5a7fd1d
feat: additions to bookmark workflow
9043721 
 - display bookmark on main page when selected
 - add persistance
 - addressed some TODOs
feat: adding the recent wallets page
42c8246
refactor: lint clean up
2d17796
chore: clean up SendToWalletCardHeader
7630982
refactor: change in export for Bookmark Item styles
cbb958e
chore: reinstate widths for ellipsis support
3567711
chore: changes following review
a6bfa3e 
- remove the id from the bookmarkWallet types and use Address as uique value
- add validation for when bookmark already exists
- make the bookmark button on the SendToWalletPage square
- remove the px from some styling values
- make cancel buttons text variants
- add padding between Add bookmark button and ListItems
- make Add Bookmark button sticky
refactor: pull CardButton into Cards component folder
93bb6f0 
- also pulling in some of the styles from the Settings page
feat: list item changes
4d3ec7c 
- adopt the list item menu styling from WalletMenu in V2
- change the WalletAvatar to use the Avatar component
- changes to ListItem to ensure it use ListItemButton for hover states
feat: chainType related changes for explore url on listItem menu
34e8198 
- also ensure no addressShortenting happen to ENS urls
refactor: make ListItem fully reusable
0a4ad92
feat: add the connected wallets page
63683e5 
- also includes some rework of the Avatars in places
chore: requested updates
02f664c
fix: ensure that the account avatar on the main page send to wallet b…
b38e909 
…utton updates correctly
feat: add in the previous disabling
a0499c6
chore: remove the toAddress and requiredToAddress checks from the Rou…
68a1286 
…tes and RoutesExpanded
fix: remove gap from the bookmark lists
a6abdfc
feat: finalising change to the validation and required functionality
6eaada2
@DNR500 DNR500 force-pushed the send-to-wallet-ux-update branch from 0e1ab47 to 6eaada2 Compare January 17, 2024 11:55
@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://795f17d4.widget-sendtowall.pages.dev

@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://58c643d6.widget-sendtowall.pages.dev

@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://f2af46c6.widget-sendtowall.pages.dev

@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://b62b416f.widget-sendtowall.pages.dev

@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://4258341b.widget-sendtowall.pages.dev

@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://c8d8d2da.widget-sendtowall.pages.dev

@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://6e5fc0e1.widget-sendtowall.pages.dev

@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://9797671c.widget-sendtowall.pages.dev

@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://eae4a810.widget-sendtowall.pages.dev

@DNR500 DNR500 removed the WIP Work in progress label Jan 19, 2024
@DNR500 DNR500 marked this pull request as ready for review January 19, 2024 17:50
@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://d96846b7.widget-sendtowall.pages.dev

@github-actions GitHub Actions
Copy link

Hey! This is your new endopint: https://40a833be.widget-sendtowall.pages.dev

@chybisov chybisov merged commit 7b41eb7 into main Jan 23, 2024
1 check passed
@chybisov chybisov deleted the send-to-wallet-ux-update branch January 23, 2024 13:33
@chybisov chybisov mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chybisov chybisov chybisov approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DNR500 @chybisov