Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rabby wallet #148

Closed
wants to merge 5 commits into from
Closed

feat: add rabby wallet #148

wants to merge 5 commits into from

Conversation

0xsebn
Copy link
Contributor

@0xsebn 0xsebn commented Oct 31, 2023

@chybisov chybisov changed the title feat:rabby wallet added feat: add rabby wallet Oct 31, 2023
@chybisov chybisov added the WIP Work in progress label Oct 31, 2023
@0xsebn
Copy link
Contributor Author

0xsebn commented Nov 1, 2023

@chybisov
Copy link
Member

chybisov commented Nov 8, 2023

Added some details on the ticket https://lifi.atlassian.net/jira/software/c/projects/LF/boards/15?assignee=6398600d3c9bcd363977188e&selectedIssue=LF-5463

We need to find a way to determine when Rabby is installed, or it will compete with MM for window.ethereum. Especially in the new implementation.

const rabbywallet: Wallet = new InjectedConnector(
{
name: 'Rabby Wallet',
installed: async () => (window as any).ethereum,
Copy link
Contributor

@Addminus Addminus Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked at the wallet injection. for the installed hook
(window as any).ethereum.isRabby
should work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually rabby wallet injects also as window.rabby we should use that instead of the window.ethereum injection

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so: installed just checks window.rabby

installed: async () => (window as any).ethereum,
icon: walletIcons.rabbywallet,
},
(window as any).ethereum,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when going with window.rabby we should pass (window as any).rabby) as injection here

@Addminus Addminus closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants