-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rabby wallet #148
Conversation
Added some details on the ticket |
We need to find a way to determine when Rabby is installed, or it will compete with MM for window.ethereum. Especially in the new implementation. |
const rabbywallet: Wallet = new InjectedConnector( | ||
{ | ||
name: 'Rabby Wallet', | ||
installed: async () => (window as any).ethereum, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked at the wallet injection. for the installed hook
(window as any).ethereum.isRabby
should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually rabby wallet injects also as window.rabby
we should use that instead of the window.ethereum injection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so: installed just checks window.rabby
installed: async () => (window as any).ethereum, | ||
icon: walletIcons.rabbywallet, | ||
}, | ||
(window as any).ethereum, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when going with window.rabby we should pass (window as any).rabby)
as injection here
jira: https://lifi.atlassian.net/jira/software/c/projects/LF/boards/15?selectedIssue=LF-5463
Will update svg once Vilen posts it on figma