-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux Hotplug: Connection-callback implementation for hidraw #647
Linux Hotplug: Connection-callback implementation for hidraw #647
Conversation
bb974de
to
436b902
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HIDAPI uses tabs for indentation
if you've noticed otherwise - thet's a "bug"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my comments are only about code-style for now
I really need to find time to review this (and others) thoroughly
9d5720e
to
43956be
Compare
Did some adjustents to the code-style (in fact, got my IDE set up to keep track of it). |
2bf0493
to
1008a83
Compare
Not so sure how to re-run the github actions as there were build error previously. |
I will test this under Linux later. |
This seems to work fine under Ubuntu Linux 20.04. Unplug and plug of a USB mouse receiver Unplug and plug of USBasp programmer (USB Composite device) Unplug and plug of Plantronics Headset (USB composite device)
More detailed output using sudo.
|
fc3491c
to
7830967
Compare
Test of latest commit under Ubuntu Linux 20.04
|
Noticed a very minor issue with this PR - the code lacks a |
Fixed the cleanup procedure. Doesn't affect how the events themselves work. |
Last git commit is still working fine. Thanks. Tested under Ubuntu Linux 20.04. Unplug and plug of Platronics USB headset
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same deal as with #645 - getting it merged into a feature branch now.
No description provided.