-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(libp2p): arch gates *-websys export and dependencies. #5891
feat(libp2p): arch gates *-websys export and dependencies. #5891
Conversation
…for -websys targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left one minor suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you bump the patch version? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Can you update the Cargo.lock
as well?
Actually, I don't think the version bump was needed. |
You're right. I think the CI was fussing about something too which prompted me to suggest that. @elijahhampton could you revert the version back to v0.55.1 and update the changelog accordingly? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @elijahhampton!
This pull request has been removed from the queue for the following reason: Pull request #5891 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:
You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
(Dequeued again because I'd like to also get an approval from @jxs that we are not accidentally breaking anything with this). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the ping Elena! I assume this should be safe, if not we'll be here to deal with the consequences! 👨⚖️
I believe it will be safe given that this is just moving any websys crates behind wasm32 target. |
Description
This merge request architecture gates *-websys dependencies to wasm in Cargo.toml and does similar arch gating in lib.rs for rexports of *-websys targets.
Closes #5885
Notes & open questions
Change checklist