Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(libp2p): arch gates *-websys export and dependencies. #5891

Conversation

elijahhampton
Copy link
Contributor

@elijahhampton elijahhampton commented Feb 25, 2025

Description

This merge request architecture gates *-websys dependencies to wasm in Cargo.toml and does similar arch gating in lib.rs for rexports of *-websys targets.

Closes #5885

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • [N/A] I have made corresponding changes to the documentation
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one minor suggestion

@elijahhampton elijahhampton changed the title Arch gates -websys export targets in lib.rs. Arch gates *-websys dependencies. chore: Arch gates -websys export targets in lib.rs. Arch gates *-websys dependencies. Feb 26, 2025
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you bump the patch version? :)

@dariusc93 dariusc93 changed the title chore: Arch gates -websys export targets in lib.rs. Arch gates *-websys dependencies. chore: arch gates *-websys export and dependencies. Feb 26, 2025
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you update the Cargo.lock as well?

@dariusc93 dariusc93 requested a review from elenaf9 February 26, 2025 03:57
@elenaf9
Copy link
Contributor

elenaf9 commented Feb 26, 2025

Thanks! Can you bump the patch version? :)

Actually, I don't think the version bump was needed. libp2p-v0.55.1 isn't released yet.

@elenaf9 elenaf9 changed the title chore: arch gates *-websys export and dependencies. feat(libp2p): arch gates *-websys export and dependencies. Feb 26, 2025
@dariusc93
Copy link
Member

Thanks! Can you bump the patch version? :)

Actually, I don't think the version bump was needed. libp2p-v0.55.1 isn't released yet.

You're right. I think the CI was fussing about something too which prompted me to suggest that.

@elijahhampton could you revert the version back to v0.55.1 and update the changelog accordingly? :)

Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elijahhampton!

@elenaf9 elenaf9 added send-it and removed send-it labels Feb 27, 2025
Copy link
Contributor

mergify bot commented Feb 27, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #5891 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • label=send-it

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@elenaf9 elenaf9 requested a review from jxs February 27, 2025 09:25
@elenaf9
Copy link
Contributor

elenaf9 commented Feb 27, 2025

(Dequeued again because I'd like to also get an approval from @jxs that we are not accidentally breaking anything with this).

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the ping Elena! I assume this should be safe, if not we'll be here to deal with the consequences! 👨‍⚖️

@jxs jxs added the send-it label Feb 27, 2025
@dariusc93
Copy link
Member

LGTM, thanks for the ping Elena! I assume this should be safe, if not we'll be here to deal with the consequences! 👨‍⚖️

I believe it will be safe given that this is just moving any websys crates behind wasm32 target.

@mergify mergify bot merged commit d41d6df into libp2p:master Feb 27, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libp2p: rexport *-websys transports only on wasm targets
4 participants