[breaking] bump required node version to 10+, update underlying lib #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantizor
changed the title
|
This looks great to my eyes, @probablyup. Is it customary to commit yarn.lock in library repos? |
|
Usually yeah, so you get consistent builds.
…Sent from my iPhone
On Sep 9, 2020, at 7:44 PM, John Hann ***@***.***> wrote:
This looks great to my eyes, @probablyup. Is it customary to commit yarn.lock in library repos?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@leebyron ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR composes #10 and adds the bits to upgrade the library for Node 10+
Note that I pinned
flow-remove-typesintentionally to the slightly lower version because the newer one is buggy as @unscriptable mentioned in their original PR.