Add title prop to the Navbar component so that overflowMenuLinks comp…

…uted property reactively updates when the AppBar title updates
learningequality · Feb 12, 2025 · 3d479e9 · 3d479e9
1 parent 8f8e488
commit 3d479e9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/kolibri/components/pages/AppBarPage/internal/AppBar.vue b/packages/kolibri/components/pages/AppBarPage/internal/AppBar.vue
@@ -58,6 +58,7 @@
               v-if="links.length > 0"
               :class="{ 'hide-navbar': !showTopNavBar }"
               :navigationLinks="links"
+              :title="title"
               @update-overflow-count="overflowCount = $event"
             />
           </slot>
@@ -127,6 +128,7 @@
         <Navbar
           v-if="links.length > 0"
           :navigationLinks="links"
+          :title="title"
         />
       </slot>
     </div>

diff --git a/packages/kolibri/components/pages/AppBarPage/internal/Navbar/index.vue b/packages/kolibri/components/pages/AppBarPage/internal/Navbar/index.vue
@@ -83,6 +83,10 @@
           return values.every(value => value.link.name);
         },
       },
+      title: {
+        type: String,
+        required: true,
+      },
     },
     data() {
       return { mounted: false };
@@ -92,7 +96,7 @@
         return this.navigationLinks.filter(l => !l.isHidden);
       },
       overflowMenuLinks() {
-        if (!this.mounted || isUndefined(this.windowWidth)) {
+        if (!this.mounted || isUndefined(this.windowWidth) || !this.title) {
           return [];
         }
         const containerTop = this.$refs.items.offsetTop;