ci: Automate release process with release please #322
Conversation
|
This pull request has been linked to Shortcut Story #227797: Update iOS SDK to use release please. |
keelerm84
force-pushed
the
mk/sc-227797/release-please
branch
from
6821b4c to
658f0d1
Compare
|
|
||
| - name: Run contract tests | ||
| shell: bash | ||
| run: sleep 5 && make run-contract-tests |
There was a problem hiding this comment.
Explanation of the sleep would be good
| - name: Push to cocoapods | ||
| if: ${{ inputs.dry_run == 'false' }} | ||
| shell: bash | ||
| run: pod trunk push LaunchDarkly.podspec --allow-warnings --verbose |
There was a problem hiding this comment.
Guessing the tool itself doesn't have a dry run mode?
There was a problem hiding this comment.
Correct. I did check originally but it doesn't appear to support it. We do perform a pod spec lint every time and that pretty much does everything except push so we should be somewhat shielded.
| pull_request: | ||
| branches: [ v8 ] | ||
| paths-ignore: | ||
| - '**.md' |
There was a problem hiding this comment.
Wondering this for other SDKs as well. Do you think it should run daily/weekly so that incompatibilities don't slip in (like the Github runner tools subtly changing?)
There was a problem hiding this comment.
Yes, I was actually thinking about this as well. This is my last PR for release please in my repos, so I'm going to work on getting this one merged, and then probably come back through everyone one final time.
Makefile
Outdated
|
|
||
| start-contract-test-service-bg: | ||
| @echo "Test service output will be captured in $(TEMP_TEST_OUTPUT)" | ||
| @make start-contract-test-service >$(TEMP_TEST_OUTPUT) 2>&1 & | ||
|
|
||
| run-contract-tests: | ||
| @curl -s https://raw.githubusercontent.com/launchdarkly/sdk-test-harness/master/downloader/run.sh \ | ||
| | VERSION=v2 PARAMS="-url http://localhost:8080 -debug -stop-service-at-end -skip-from ./ContractTests/testharness-suppressions.txt $(TEST_HARNESS_PARAMS)" sh | ||
| | VERSION=v2 PARAMS="-url http://0.0.0.0:8080 -debug -stop-service-at-end -skip-from ./ContractTests/testharness-suppressions.txt $(TEST_HARNESS_PARAMS)" sh |
There was a problem hiding this comment.
Was localhost not working?
There was a problem hiding this comment.
It might actually work. I was running into some other problems originally with this and tried that first. I'll revert and see if it runs through.
No description provided.