Skip to content

Commit

Permalink
initial commit
Browse files Browse the repository at this point in the history
  • Loading branch information
lalitb committed Aug 12, 2024
1 parent fe2fb96 commit 5781f50
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 21 deletions.
19 changes: 8 additions & 11 deletions opentelemetry-sdk/src/logs/record.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use std::{borrow::Cow, time::SystemTime};
/// is provided to `LogExporter`s as input.
pub struct LogRecord {
/// Event name. Optional as not all the logging API support it.
pub event_name: Option<Cow<'static, str>>,
pub event_name: Option<&'static str>,

/// Target of the log record
pub target: Option<Cow<'static, str>>,
Expand All @@ -38,11 +38,8 @@ pub struct LogRecord {
}

impl opentelemetry::logs::LogRecord for LogRecord {
fn set_event_name<T>(&mut self, name: T)
where
T: Into<Cow<'static, str>>,
{
self.event_name = Some(name.into());
fn set_event_name(&mut self, name: &'static str) {
self.event_name = Some(name);
}

// Sets the `target` of a record
Expand Down Expand Up @@ -154,7 +151,7 @@ mod tests {
fn test_set_eventname() {
let mut log_record = LogRecord::default();
log_record.set_event_name("test_event");
assert_eq!(log_record.event_name, Some(Cow::Borrowed("test_event")));
assert_eq!(log_record.event_name, Some("test_event"));
}

#[test]
Expand Down Expand Up @@ -247,7 +244,7 @@ mod tests {
#[test]
fn compare_log_record() {
let log_record = LogRecord {
event_name: Some(Cow::Borrowed("test_event")),
event_name: Some("test_event"),
target: Some(Cow::Borrowed("foo::bar")),
timestamp: Some(SystemTime::now()),
observed_timestamp: Some(SystemTime::now()),
Expand All @@ -267,20 +264,20 @@ mod tests {
assert_eq!(log_record, log_record_cloned);

let mut log_record_different = log_record.clone();
log_record_different.event_name = Some(Cow::Borrowed("different_event"));
log_record_different.event_name = Some("different_event");

assert_ne!(log_record, log_record_different);
}

#[test]
fn compare_log_record_target_borrowed_eq_owned() {
let log_record_borrowed = LogRecord {
event_name: Some(Cow::Borrowed("test_event")),
event_name: Some("test_event"),
..Default::default()
};

let log_record_owned = LogRecord {
event_name: Some(Cow::Owned("test_event".to_string())),
event_name: Some("test_event"),
..Default::default()
};

Expand Down
6 changes: 1 addition & 5 deletions opentelemetry/src/logs/noop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ pub struct NoopLogRecord;
impl LogRecord for NoopLogRecord {
// Implement the LogRecord trait methods with empty bodies.
#[inline]
fn set_event_name<T>(&mut self, _name: T)
where
T: Into<Cow<'static, str>>,
{
}
fn set_event_name(&mut self, _name: &'static str) {}
#[inline]
fn set_timestamp(&mut self, _timestamp: SystemTime) {}
#[inline]
Expand Down
6 changes: 1 addition & 5 deletions opentelemetry/src/logs/record.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@ use std::{borrow::Cow, collections::HashMap, time::SystemTime};
/// SDK implemented trait for managing log records
pub trait LogRecord {
/// Sets the `event_name` of a record
fn set_event_name<T>(&mut self, _name: T)
where
T: Into<Cow<'static, str>>,
{
}
fn set_event_name(&mut self, _name: &'static str);

/// Sets the `target` of a record.
/// Currently, both `opentelemetry-appender-tracing` and `opentelemetry-appender-log` create a single logger
Expand Down

0 comments on commit 5781f50

Please sign in to comment.