-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom public address in generated configurations #8
Conversation
I started with adding URL parameters for public IP/port, and I have my first questions
Update: removed port handling, I realized it's unrelated from this feature. |
Pull Request Test Coverage Report for Build 12931715286Details
💛 - Coveralls |
fd3e225
to
6b8cded
Compare
e11d557
to
e2f6e28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there, only minor stuff missing. Once ready please try to repack the whole thing into a single commit so that we can simply git-merge and still get a clean history. Thx!!!
dd50b2c
to
df0d645
Compare
I have now made fixes and squashed all commits into one. Thanks for your comments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the nitpicking again. I promise this is the last time. Let me know if you're fed up with this and want me to jump in and to the renamings all over the place
df0d645
to
e50d49a
Compare
e50d49a
to
a53b400
Compare
Thanks, and no worries at all! I should have done this by myself after you recommended to change the env variable. I have made the fixes, let's see how it looks now and still correct what's necessary. |
Thanks a lot, applied! |
Fixes #1