Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
components/kcp/pkg/common/actions/scope
actions intocomponents/kcp/pkg/kcp/scope
cloudcontrolv1beta1
resourcesScopeRef
requiredKymaName
since it should be read from the Scopefocal
flow to set error condition and stop/forget if referred Scope does not existfocal.CommonObject
and removedKymaName()
since it's removed from the resources, and embeddedcomposed.ObjWithConditions
as a replacement forConditions()
andGetObjectMeta()
components/kcp/pkg/common/actions/scope
flow from all existing reconcilerscomponents/kcp/pkg/skr/iprange
to create KCP IpRange w/out deletedKymaName
and with requiredScopeRef
skrlooper.ActiveSkrCollection
interface fromskrlooper.SkrLooper
withAddKymaName()
andRemoveKymaName()
methods, to be provided to the flow actions to start/stop SKR reconciliations, w/out giving them reference to the wholeSkrLooper
util.GetKymaModuleState()
, typeutil.KymaModuleState
, and related consts to match LifecycleManager implementationSetObj()
to thecomposed.State
due to a non-standard Scope flow when it's triggered by the watched Kyma in case when Scope does not exist, so it can be set to the state once createdAdd()
callsRelated issue(s)