chore(AwsRedisInstance): add shardcount to client (#1036)

kyma-project · Feb 18, 2025 · d39a49f · d39a49f
1 parent e9ebf88
commit d39a49f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/pkg/kcp/provider/aws/client/elastiCacheClient.go b/pkg/kcp/provider/aws/client/elastiCacheClient.go
@@ -45,7 +45,8 @@ type CreateElastiCacheClusterOptions struct {
 	AuthTokenSecretString      *string
 	PreferredMaintenanceWindow *string
 	SecurityGroupIds           []string
-	ReplicasPerNodeGroup       int32
+	ReplicasPerNodeGroup       int32 // replicas per shard
+	ShardCount                 *int32
 }
 
 type ModifyElastiCacheClusterOptions struct {
@@ -316,14 +317,21 @@ func (c *client) DescribeElastiCacheReplicationGroup(ctx context.Context, cluste
 
 func (c *client) CreateElastiCacheReplicationGroup(ctx context.Context, tags []elasticacheTypes.Tag, options CreateElastiCacheClusterOptions) (*elasticache.CreateReplicationGroupOutput, error) {
 	automaticFailoverEnabled := options.ReplicasPerNodeGroup > 0
+
+	shardCount := ptr.Deref(options.ShardCount, 1)
+	clusterMode := elasticacheTypes.ClusterModeDisabled
+	if shardCount > 1 {
+		clusterMode = elasticacheTypes.ClusterModeEnabled
+	}
+
 	params := &elasticache.CreateReplicationGroupInput{
 		ReplicationGroupId:          aws.String(options.Name),
 		ReplicationGroupDescription: aws.String("ElastiCache managed by Kyma Cloud Manager"),
 		CacheSubnetGroupName:        aws.String(options.SubnetGroupName),
 		CacheParameterGroupName:     aws.String(options.ParameterGroupName),
 		CacheNodeType:               aws.String(options.CacheNodeType),
-		NumNodeGroups:               aws.Int32(1),
-		ClusterMode:                 elasticacheTypes.ClusterModeDisabled,
+		NumNodeGroups:               aws.Int32(shardCount),
+		ClusterMode:                 clusterMode,
 		Engine:                      aws.String("redis"),
 		EngineVersion:               aws.String(options.EngineVersion),
 		AutoMinorVersionUpgrade:     aws.Bool(options.AutoMinorVersionUpgrade),

diff --git a/pkg/kcp/provider/aws/mock/elastiCacheClientFake.go b/pkg/kcp/provider/aws/mock/elastiCacheClientFake.go
@@ -345,6 +345,10 @@ func (client *elastiCacheClientFake) CreateElastiCacheReplicationGroup(ctx conte
 		UserGroupIds:             []string{},
 		Engine:                   ptr.To("redis"),
 		AtRestEncryptionEnabled:  ptr.To(true),
+		ConfigurationEndpoint: &elasticacheTypes.Endpoint{
+			Address: ptr.To("192.168.3.2"),
+			Port:    aws.Int32(6949),
+		},
 		NodeGroups: []elasticacheTypes.NodeGroup{
 			{
 				PrimaryEndpoint: &elasticacheTypes.Endpoint{