Api State Removal - backend #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
cla: yes
9 tasks
MarekMichali
force-pushed
the
api-central-secret
branch
2 times, most recently
from
e871268 to
1a520c9
Compare
MarekMichali
force-pushed
the
api-central-secret
branch
from
1a520c9 to
12af71b
Compare
…/dev/btp-manager:PR-844
kyma-bot
removed
the
do-not-merge/work-in-progress
ralikio
reviewed
Aug 27, 2024
ralikio
reviewed
Aug 27, 2024
internal/api/api.go
Outdated
| router.HandleFunc("POST /api/service-bindings", a.CreateServiceBinding) | ||
| router.HandleFunc("DELETE /api/service-bindings/{id}", a.DeleteServiceBinding) |
ralikio
reviewed
Aug 27, 2024
internal/api/api.go
Outdated
| router.HandleFunc("GET /api/service-offerings/{id}", a.GetServiceOffering) | ||
| router.HandleFunc("GET /api/service-instances", a.ListServiceInstances) | ||
| router.HandleFunc("GET /api/service-instances/{id}", a.GetServiceInstance) | ||
| router.HandleFunc("GET /api/service-offerings", a.HandleGetServiceOffering) |
There was a problem hiding this comment.
Reverted to the ID's in the path so it's gone
ralikio
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always require sm_secret_namespace and sm_secret_name URL parameters for API calls. Add an interface to test API calls that require SMClient
Changes proposed in this pull request:
Related issue(s)
See #442