fix: Theming when saving a figure #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kunzaatko
commented
Jan 9, 2025
kunzaatko
commented
- docs(themes): improve function documentation and error messages
- refactor(save-fig)!: improve format handling and theme management
- test: add unit tests for get_formats function
- refactor: move LaTeXStrings import to main module and re-export it
- refactor(savefig)!: improve figure saving workflow and documentation
- feat(themes): add A4 paper size constants
- docs(workflows): restructure documentation and add figure export guide
- enhance savefig function documentation with clearer parameter descriptions - add detailed documentation for screen_parameters and get_interactive_size - fix typo in ScreenInfo struct (dimesions -> dimensions) - improve error handling for screen detection - add cross-references between related functions - update TODOs with new implementation notes
- Add get_formats function to handle format validation and ordering - Improve backend_formats function readability - Replace theme_dict with direct theme generation - Add better error handling for incompatible formats - Add comprehensive jldoctest examples BREAKING CHANGE: Remove theme_dict parameter from savefig function
- Add tests for format validation with CairoMakie - Add test for automatic SVG format inclusion - Add test for invalid format combinations
- Move `name` parameter before `width` and `hwratio` for better argument order - Remove `update` parameter from main function signature - Add automatic naming for multiple figures with "_i" suffix - Extract PDF/TeX saving logic into separate `_savepdftex` function - Add documentation for `ScreenInfo` struct - Simplify backend-specific save logic - Remove redundant vector figure handling function
Add A4 paper dimensions as constants (210mm x 297mm) with TODO note for future paper sizes
feat: add comprehensive guide for publication figure exports - Move workflow content into dedicated subdirectory - Add detailed examples for figure theming and export sizes - Include Bessel function visualization examples - Add SpecialFunctions as documentation dependency
|
Fixes #2 |
kunzaatko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.