fix: Make Rego inventories ordered and deterministic #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viccuad
force-pushed
the
deterministic-inventory
branch
from
82e8fc5 to
cabefc7
Compare
fabriziosestito
force-pushed
the
deterministic-inventory
branch
2 times, most recently
from
849b75f to
441ead1
Compare
viccuad
commented
Nov 23, 2023
flavio
approved these changes
Nov 23, 2023
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
fabriziosestito
force-pushed
the
deterministic-inventory
branch
from
441ead1 to
4269e27
Compare
fabriziosestito
approved these changes
Nov 23, 2023
Merged
flavio
added a commit
to flavio/kwctl
that referenced
this pull request
Nov 24, 2023
- fix: Make Rego inventories ordered and deterministic (kubewarden#655) - Update many deps Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure the rego inventory of Kubernetes resources is built in a deterministic way. Without that, a
kwctl runoutcome might fail without a valid reason.This issue was reported by @brunorene
This depends on kubewarden/policy-evaluator#389