fix(AM-12246): apply EKS specific annotations for NLB creation #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mridul <mridulgain@gmail.com>
mridulgain
requested review from
narmidm,
bharath-avesha,
Rahul-D78 and
gourishkb
as code owners
narmidm
approved these changes
Dec 19, 2023
mridulgain
added a commit
that referenced
this pull request
Jan 10, 2024
* fix(AM-12246): apply EKS specific annotations for NLB creation (#325) Signed-off-by: Mridul <mridulgain@gmail.com> * fix(deps): bump tj-actions/branch-names in /.github/workflows (#323) Bumps [tj-actions/branch-names](https://github.com/tj-actions/branch-names) from 6 to 7.0.7. - [Release notes](https://github.com/tj-actions/branch-names/releases) - [Changelog](https://github.com/tj-actions/branch-names/blob/main/HISTORY.md) - [Commits](tj-actions/branch-names@v6...v7.0.7) --- updated-dependencies: - dependency-name: tj-actions/branch-names dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(deps): bump golang.org/x/crypto from 0.11.0 to 0.17.0 (#324) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.11.0 to 0.17.0. - [Commits](golang/crypto@v0.11.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(): go fmt Signed-off-by: Mridul <mridulgain@gmail.com> --------- Signed-off-by: Mridul Gain <mridulgain@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mridulgain
added a commit
that referenced
this pull request
Feb 16, 2024
* fix(): Integration with Envoy Gateway Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> * fix(): Upgrade controller-runtime lib - p1 Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> * fix(): Upgrade controller-runtime lib - p2 Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> * fix(): Upgrade controller-runtime lib - p3 Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> * fix(): Upgrade controller-runtime lib - p4 Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> * fix(): Upgrade controller-runtime lib - p5 Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> * Master sync (#328) * fix(AM-12246): apply EKS specific annotations for NLB creation (#325) Signed-off-by: Mridul <mridulgain@gmail.com> * fix(deps): bump tj-actions/branch-names in /.github/workflows (#323) Bumps [tj-actions/branch-names](https://github.com/tj-actions/branch-names) from 6 to 7.0.7. - [Release notes](https://github.com/tj-actions/branch-names/releases) - [Changelog](https://github.com/tj-actions/branch-names/blob/main/HISTORY.md) - [Commits](tj-actions/branch-names@v6...v7.0.7) --- updated-dependencies: - dependency-name: tj-actions/branch-names dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(deps): bump golang.org/x/crypto from 0.11.0 to 0.17.0 (#324) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.11.0 to 0.17.0. - [Commits](golang/crypto@v0.11.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(): go fmt Signed-off-by: Mridul <mridulgain@gmail.com> --------- Signed-off-by: Mridul Gain <mridulgain@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(): go vet Signed-off-by: Mridul <mridulgain@gmail.com> * fix(): Revert slice gw proto change code Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> * fix(): Webhook changes for overlay type Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> * fix(): Update kubeslice apis pkg version Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> * feat(): HTTPS support for multinet slice Signed-off-by: Mridul Gain <mridulgain@gmail.com> * phase1 supports HTTP & HTTPS Signed-off-by: Mridul Gain <mridulgain@gmail.com> * default value for ServiceProtocol Signed-off-by: Mridul Gain <mridulgain@gmail.com> * fix(): Add status for service protocol in svcex Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> * adding servicePorts in printercoloumn Signed-off-by: Mridul Gain <mridulgain@gmail.com> * using latest tags for apis Signed-off-by: Mridul Gain <mridulgain@gmail.com> * Merge branch 'master' into feature-envoy-gw Signed-off-by: Mridul Gain <mridulgain@gmail.com> * fix(): broken UTs for cluster and VPN Signed-off-by: gourishkb <104021126+gourishkb@users.noreply.github.com> Signed-off-by: Mridul Gain <mridulgain@gmail.com> * fix(): remove unused code, fix slicegw IT Signed-off-by: gourishkb <104021126+gourishkb@users.noreply.github.com> Signed-off-by: Mridul Gain <mridulgain@gmail.com> * skipping failed IT Signed-off-by: Mridul Gain <mridulgain@gmail.com> --------- Signed-off-by: Bharath Horatti <bharath@aveshasystems.com> Signed-off-by: Mridul Gain <mridulgain@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: gourishkb <104021126+gourishkb@users.noreply.github.com> Co-authored-by: Bharath Horatti <bharath@aveshasystems.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gourishkb <104021126+gourishkb@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
The LB is getting stuck into "pending" state on aws when protocol is TCP
https://avesha.atlassian.net/browse/AM-12246
How Has This Been Tested?
Checklist:
go fmtDoes this PR introduce a breaking change?